Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/main page 메인 페이지 수정 #13

Merged
merged 24 commits into from
Sep 5, 2024
Merged

Feature/main page 메인 페이지 수정 #13

merged 24 commits into from
Sep 5, 2024

Conversation

2NNS-V
Copy link
Collaborator

@2NNS-V 2NNS-V commented Sep 4, 2024

구현한 기능

  • 메인 페이지에서 img 추가
  • 드롭다운 컴포넌트 추가 및 적용
  • 통계 페이지 퍼블리싱
  • 전역 변수 설정
  • 동아리 로고 Footer 컴포넌트 추가
  • png -> svg 확장자명 변경

논의하고 싶은 내용

기타

  • 통계페이지 디자인은 아직 수정중

2NNS-V added 16 commits August 29, 2024 00:49
@2NNS-V
feat:통계 페이지로 이동
e8cc5d1
@2NNS-V
Merge branch 'develop' of https://github.com/LikeLion-KNU/dongBTI int…
78b93a7 
…o feature/main-page
@2NNS-V
design:백그라운드 이미지 추가
8c01947
@2NNS-V
design:사이드바 hover 이벤트 추가
2fba2ad
@2NNS-V
design:input 폰트 크기 설정 및 padding 설정
05544e9
@2NNS-V
feat:단과대학 dropdown 추가 및 적용
b758800
@2NNS-V
design:background image 삭제
5d60e10
@2NNS-V
chore: png->svg로 확장자명 변경
4044c5c
@2NNS-V
style:sidebar 블러 효과 수정
eaa0a5a
@2NNS-V
feat: 변경된 디자인에 맞게 수정 및 전역 상태(name, major) 설정
2ca349a
@2NNS-V
style: input 글씨체 설정
e318461
@2NNS-V
refact: 이름 명시적으로 수정
1a6eacf
@2NNS-V
feat:통계 페이지 진행중
e7769a2
@2NNS-V
feat:메인 페이지에 이미지 추가
d16ece1
@2NNS-V
feat:동아리 로고 Footer 추가
aaff2e1
@2NNS-V
feat:Footer 적용 및 메인 이미지 반응형 적용
b656022
@2NNS-V 2NNS-V requested a review from toothlessdev September 4, 2024 15:03
@2NNS-V 2NNS-V self-assigned this Sep 4, 2024
@2NNS-V 2NNS-V added the enhancement New feature or request label Sep 4, 2024
toothlessdev
toothlessdev requested changes Sep 4, 2024
View reviewed changes
src/components/display/Footer.tsx Outdated Show resolved Hide resolved
src/components/form/Dropdown.tsx Outdated Show resolved Hide resolved
src/components/navigation/SideBar.tsx Outdated Show resolved Hide resolved
toothlessdev
toothlessdev approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! any 는 최대한 피하고 명시적으로 타입을 지정하는 습관을 들이면 좋을것 같아요!

2NNS-V and others added 4 commits September 5, 2024 11:50
@2NNS-V
Rename:Dropdown.tsx to DropDown.tsx
87146ab
@2NNS-V
Rename:Dropdown.style.ts to DropDown.style.ts
d8d2d1a
@2NNS-V
refact: DropDown 코드 리팩토링
9876bae 
- LabelContainer 타입 명시
- Label과 DropDown에서 공통되는 Background color 로직 추출
- DropDownProps 하나로 처리
@2NNS-V
refact: SideBar 관련 함수 타입 지정
8b06a10
toothlessdev
toothlessdev approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@toothlessdev toothlessdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@2NNS-V 2NNS-V merged commit 442b77f into develop Sep 5, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toothlessdev toothlessdev toothlessdev approved these changes

Assignees

@2NNS-V 2NNS-V

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2NNS-V @toothlessdev